Skip to content

feat: create outbound app from template#744

Merged
aviadl merged 1 commit into
mainfrom
outbound-app-create-from-template
Jun 21, 2026
Merged

feat: create outbound app from template#744
aviadl merged 1 commit into
mainfrom
outbound-app-create-from-template

Conversation

@aviadl

@aviadl aviadl commented Jun 21, 2026

Copy link
Copy Markdown
Member

@aviadl aviadl requested a review from talaharoni June 21, 2026 11:10
@shuni-bot-dev

shuni-bot-dev Bot commented Jun 21, 2026

Copy link
Copy Markdown

🐕 Starting automated code review...

Analyzing changes...

@shuni-bot-dev

shuni-bot-dev Bot commented Jun 21, 2026

Copy link
Copy Markdown

🐕 Suggested Reviewers

Selected reviewers are those who have recently contributed to the core files affected by this pull request, ensuring they have recent context and familiarity with the code areas involved.

Reviewer Reason
oruis123 Recently modified 'lib/management/outboundapplication.test.ts' and 'lib/management/outboundapplication.ts', so likely familiar with the main functional areas impacted by this change.
talaharoni Contributed to 'lib/management/outboundapplication.test.ts' and 'lib/management/outboundapplication.ts', covering key files related to the new outbound app feature.
itaihanski Recently worked on 'lib/management/outboundapplication.ts' and testing files, making them well-suited to review both implementation and tests.
ckiee Contributed to 'lib/management/paths.ts', indicating knowledge of path management which may be relevant for the new feature.
yosiharan Modified 'lib/management/types.ts', providing insight into type definitions potentially impacted by this change.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@aviadl aviadl enabled auto-merge (squash) June 21, 2026 11:36
@aviadl aviadl merged commit 868a081 into main Jun 21, 2026
28 checks passed
@aviadl aviadl deleted the outbound-app-create-from-template branch June 21, 2026 11:48
talaharoni added a commit that referenced this pull request Jun 22, 2026
These fields were added to OutboundAppTemplateOverrides in #744 but not to
OutboundApplication, forcing a cast when creating DCR-based outbound apps via
createApplication. The REST create endpoint already accepts them, so this types
create/update/load correctly with no cast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support creating Outbound Apps from the preconfigured app library (templates) via the SDK

2 participants