Feat: Added base_url to DescopeClient
#691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaokevin1
requested review from
aviadl,
Copilot,
guyp-descope and
talaharoni
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to override the base URL in the Python SDK by introducing a base_url parameter to the DescopeClient constructor. This enables users to connect to different Descope API environments beyond the default.
Key Changes:
- Added optional
base_urlparameter toDescopeClient.__init__() - The parameter is passed to the auth HTTP client initialization
- Added test coverage to verify the base URL is correctly propagated to both auth and management HTTP clients
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| descope/descope_client.py | Added base_url parameter to constructor and passed it to auth HTTP client |
| tests/test_descope_client.py | Added test to verify base URL setting in both auth and management clients |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
|
Can we test if |
dorsha
requested changes
Nov 25, 2025
guyp-descope
approved these changes
Nov 25, 2025
dorsha
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/12954
Related PRs
Description
Added the ability to override the base URL in the Python SDK from
DescopeClientas a parameter.Must