Load users by ID #698
Merged
Load users by ID #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ tests related to descope/etc#12741
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to load users by their IDs through a new load_users method in the user management module, addressing issue #12741.
- Adds
load_usersmethod to retrieve multiple users by their IDs with optional flag to include invalid users - Includes comprehensive test coverage for success and failure scenarios
- Updates documentation with usage example
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| descope/management/user.py | Implements load_users method with validation and API integration |
| descope/management/common.py | Adds new API endpoint path for users load operation |
| tests/management/test_user.py | Adds comprehensive test cases covering error and success flows |
| README.md | Documents the new functionality with usage example |
| .vscode/settings.json | Updates VS Code workspace color theme settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
omercnet
reviewed
Dec 2, 2025
omercnet
reviewed
Dec 2, 2025
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/user.py
descope/management/common.py
|
dorsha
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/descope/etc/issues/12741