ci: enforce semantic commit conventions for releases#730
Merged
Conversation
omercnet
approved these changes
Dec 31, 2025
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes descope/etc#13479
✅ Implementation Complete
I've successfully integrated semantic commit enforcement for the Python SDK to ensure proper release-please integration. Here's what was implemented:
Changes Made:
1. Pre-commit Hook for Commit Messages (
.pre-commit-config.yaml)conventional-pre-commithook that validates commit messages locallycommit-msgstage with strict validation.commitlintrc.yamlconfiguration2. CI Check for PR Titles (
.github/workflows/ci.yml)validate-pr-titlejob that runs on all pull requestsamannn/action-semantic-pull-requestactionSupported Semantic Types:
Both validations enforce these commit types:
feat- New featuresfix- Bug fixesdocs- Documentation changesstyle- Code style changesrefactor- Code refactoringperf- Performance improvementstest- Test additions/changesbuild- Build system changesci- CI configuration changeschore- Maintenance tasksrevert- Reverting changesHow It Works:
Note:
The existing
.commitlintrc.yamlconfiguration was already in place and properly configured, so no changes were needed there. The implementation aligns with the existing release-please configuration inrelease-please-config.json.Created by Shuni 🐕