Skip to content

Modular Router GUI inaccessible when on Sable sublevel (1.21.1) #306

Description

@FyreDraygg

Describe the bug

When a Modular Router is located in a Sable sublevel (in my case on a Create Aeronautics simulated contraption) its GUI becomes inaccessible. More precisely, it tries to open but closes itself immediately.
This behaviour seems very similar to how the game automatically kicks the player out of a GUI screen if they are moved too far from the block it belongs to.
My hypothesis would be that Modular Routers, being unaware of Sable sublevels, tries to compute the distance from the player to the Modular Router "traditionally" and comes up with a ludicrous figure since blocks in Sable sublevels are technically placed at huge coordinate offsets. I know nothing about your codebase though, so it's just an uneducated guess.
Everything else appears to be functioning normally when simulated, even advanced behaviours like extrusion modules, so it's such an annoying setback from what's probably just a really minor gotcha!

How to reproduce the bug

  1. Install Create, Sable, Create Aeronautics, and Modular Routers
  2. Create a Sable sublevel by simulating some blocks via the Create Aeronautics Physics Assembler
  3. Either place a Modular Router on the simulated contraption or simulate it along with the contraption to begin with
  4. Try to access the Modular Router GUI. It will briefly flicker open then disappear immediately.

The versions I used are:
Minecraft 1.21.1
NeoForge 21.1.234
Modular Routers 13.2.5
Create 6.0.10
Create Aeronautics 1.3.0
Sable 2.0.3
(Sodium 0.8.12b2)

Expected behavior

The GUI should remain open and allow player interaction.

Additional details

Here is a video of the issue in action.
Only Sable, Create, Create Aeronautics, Modular Routers and Sodium are present. The issue is demonstrated on a freshly created world. The video also shows a couple of other unintended interactions, such as the Modular Router buffer contents spilling out upon simulation and extruded blocks behaving weirdly with sublevel splitting. I don't consider these to be as important, but I can file separate issues for these at your convenience.

ModularRouter_Sable_Test.mp4

(please forgive the poor visual quality, I had to compress this quite a bit to meet GitHub limitations)

Which Minecraft version are you using?

1.21

Crash log

No response

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions