Skip to content

captcha support#1533

Merged
julianlam merged 9 commits into
NodeBB:masterfrom
akhoury:master
May 17, 2014
Merged

captcha support#1533
julianlam merged 9 commits into
NodeBB:masterfrom
akhoury:master

Conversation

@akhoury
Copy link
Copy Markdown
Member

@akhoury akhoury commented May 16, 2014

  • added a new filter:register.build that allows adding a data.captcha html value to the register template data, also made its response add an ?error=message param to the /register url
  • modified hook filter:register.check arguments
  • added few utils functions, check them out, they're cool
  • minor other fixes

@akhoury
Copy link
Copy Markdown
Member Author

akhoury commented May 16, 2014

parallel required PR: NodeBB/nodebb-theme-vanilla#13

Comment thread public/src/app.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move var hash up with search as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@psychobunny
Copy link
Copy Markdown
Contributor

💯

julianlam added a commit that referenced this pull request May 17, 2014
@julianlam julianlam merged commit e43ebb0 into NodeBB:master May 17, 2014
@julianlam
Copy link
Copy Markdown
Member

Just wondering how passing in a data.captcha will get a CAPTCHA rendered 😄 -- looking forward to it in spam-be-gone!

@akhoury
Copy link
Copy Markdown
Member Author

akhoury commented May 17, 2014

I will publish spambegone tonight.
On May 17, 2014 4:02 PM, "Julian Lam" notifications@github.com wrote:

Just wondering how passing in a data.captcha will get a CAPTCHA rendered [image:
😄] -- looking forward to it in spam-be-gone!


Reply to this email directly or view it on GitHubhttps://github.com//pull/1533#issuecomment-43422714
.

@akhoury
Copy link
Copy Markdown
Member Author

akhoury commented May 19, 2014

holding the spam-be-gone publish because of this #1540

@akhoury
Copy link
Copy Markdown
Member Author

akhoury commented May 19, 2014

published spam-be-gone 0.2.0 with minver 0.5.0, since it's still waiting on NodeBB/nodebb-theme-vanilla#13

https://www.npmjs.org/package/nodebb-plugin-spam-be-gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants