Add TextSearchProvider #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ethereum-code-viewer ready! Built with commit 3107291 ✅ Preview: https://ethereum-code-viewer-8cmwaiv25-dethcrypto.vercel.app This pull request is being automatically deployed with vercel-action |
|
Deploy preview for ethereum-code-viewer ready! Built with commit 21124d6 ✅ Preview: https://ethereum-code-viewer-4wd7a9h3x-dethcrypto.vercel.app This pull request is being automatically deployed with vercel-action |
|
Deploy preview for ethereum-code-viewer ready! Built with commit ebdbfa5 ✅ Preview: https://ethereum-code-viewer-f3b5iqzv4-dethcrypto.vercel.app This pull request is being automatically deployed with vercel-action |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #26. Finally got it to work 🥳 tho it took more reverse engineering than I expected.
There's still a lot of work ahead, like tests, support for all buttons in search UI, and using our instance of FileSystemProvider instead of the dict of downloaded files (we currently don't support searching in user-created files.), but it's a nice improvement for the base use case I think.