MIT license, brow setup command, install e2e on linux+macos#28
Merged
Conversation
- Revert license to MIT (was Elastic 2.0); fix badges and pyproject - Add `brow setup` to install Chromium; friendly 503 when browser missing - Add scripts/e2e.sh clean-room test (wheel install -> setup -> session e2e) - Add install-e2e workflow (ubuntu+macos x py3.12/3.13) building from wheel - Add Dockerfile.e2e and fix Dockerfile to dogfood `brow setup` - Lead README headline with benchmark proof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pyproject.toml; README footer was already claiming MIT.brow setupcommand installs Chromium (patchright install chromium), sopip install brow-cli && brow setupis the full path. Friendly 503 "Chromium is not installed. Run: brow setup" instead of a raw 500 traceback when the browser binary is missing.scripts/e2e.sh— hermetic clean-room test: builds/installs the wheel, runsbrow setupthen a real session (navigate → snapshot → eval → click).install-e2e.yml— matrix{ubuntu, macos} × {3.12, 3.13}, installs from the built wheel (real user path) and runs the e2e. This is the only way to validate the macOS install.Dockerfile.e2e+ fixedDockerfileto dogfoodbrow setup(it calledplaywright install, but the package ships patchright).Verified locally
scripts/e2e.sh→ PASS (brow setupinstalls Chromium, full session e2e works).Notes
python33.9.6 is correctly rejected byrequires-python >=3.12— possible follow-up to lower the floor.🤖 Generated with Claude Code