fix: Figma Section export의 벡터 로고 누락 수정 - #9
Merged
Conversation
Contributor
Changepacksdevup-mcp@0.2.1 → 0.3.0 - crates/devup-mcp/Cargo.tomlMinor
Patch
devup-mcp-devup-ui@0.2.1 → 0.3.0 - crates/devup-mcp-devup-ui/Cargo.tomlMinor
devup-mcp-figma@0.2.1 → 0.3.0 - crates/devup-mcp-figma/Cargo.tomlMinor
Patch
devup-mcp-visual@0.2.1 → 0.2.2 - crates/devup-mcp-visual/Cargo.tomlPatch
|
The gate refuses a pull request that edits crates without one, because a change that never moves the version never releases - it would have landed on main and stayed there.
owjs3901
added a commit
that referenced
this pull request
Sep 8, 2026
Both sides changed validate_fidelity: #9 counts a declared child that no asset represents against node coverage, this branch stops counting a variable binding that a multi-colour asset baked into a file. They are the same rule read from two directions - expect what the generator could have produced, and nothing else - so the merge keeps both. Verified on the merged tree: fmt, clippy -D warnings, the whole suite and insta.
This was referenced Sep 8, 2026
owjs3901
added a commit
that referenced
this pull request
Sep 8, 2026
…ose from (#13) A Section link answers with candidates rather than screens, and the list gave a name, a type and a URL. That is not enough to tell two frames apart when a designer named them alike, so the choice was a guess and the wrong guess costs a full export. Each candidate now carries a preview of the visible text under it, bounded to 120 characters per candidate, 64 nodes walked, and 2 KiB across the whole list, so the index stays compact. An empty or short preview means the walk found little text, not that the screen is empty. The list also says how complete it is - selection.status and selection.count - with truncated read from the index rather than inferred from a round count of 100, which called a Section holding exactly that many partial. And nextAction carries an example built from this call's own artifactId and a candidate actually in the list, so the next step is a call to run rather than a shape to assemble. Taken from #10, which also re-implemented the multi-root cursor handling that #9 already landed; only the selection-list half is here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
Section의 화면을 export할 때 첫 페이지 이후의 커서를 읽지 않아 Boolean 로고의 벡터 자식 12개가 누락되고 단색 사각형으로 출력되던 문제를 수정합니다.
실제 재현 검증
Figma 파일
85CgSws3o5XsLv7aAwWJyS, Section4279:7810, 화면3831:10708,3831:10723을 수정한 release 바이너리에서 캐시 없이refresh: true로 export했습니다.두 SVG는 각각 606바이트이며 manifest·파일 SHA-256·sourceMap·TSX 참조가 일치합니다. 테마 출력은 동일하며, 같은 frameIds로 artifact를 재사용하면 추가 Figma 호출 없이 동일한 snapshot과 TSX를 반환합니다. 설치된 MCP와 다른 프로젝트 워크트리는 변경하지 않았습니다.
검증
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-features: 476 passed, 2 opt-in live tests ignoredcargo insta test --workspace --all-features --checknode --test crates/devup-mcp-figma/tests/explore_script_behavior.mjs: 4 passedcargo build --workspace --release자세한 원인과 실행 바이너리 정보는
docs/figma-vector-export-regression.md에 기록했습니다. 대용량 실제 export JSON과 바이너리는 커밋하지 않았습니다.