Harden Solavin for research-grade I-V analysis - #2
Merged
Conversation
✅ Deploy Preview for solavin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dev-juy
marked this pull request as ready for review
July 30, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The prior implementation could silently convert missing measurements to zero, align channels by row rather than voltage, display an unbracketed open-circuit voltage as exact, calculate downstream metrics from unsupported values, and visually smooth data into shapes that were never measured. Those behaviors are unacceptable for research visualization.
Validation
npm audit --audit-level=high: 0 vulnerabilities.Research scope and limitations
This change makes the system fail transparently outside its validated scope; it does not claim IEC certification or universal correctness. Series and shunt resistance remain local diagnostic estimates, uncertainty propagation is not implemented, hysteresis requires separate forward/reverse sweeps, and instrument calibration remains the researcher’s responsibility. See
docs/VALIDATION.mdfor the full validation register.