v0.4.10: severity follows reachability for a gained port too - #8
Merged
Conversation
…new one v0.4.8 taught the tool that a loopback-only binding is a different claim from `*:4444`, but wired that rule into the `added` path only. So an ssh local port-forward reported as `listener ssh now ALSO on port(s) 127.0.0.1:8080` at ORANGE — above the notify threshold — while the identical binding on a brand new process was YELLOW. Same binding, same reachability, two different answers depending on whether the process was already in the baseline. A gained port that is loopback-only is now YELLOW; one public port among loopback ones keeps the whole finding ORANGE; a bare port from a pre-0.4.8 snapshot is still unknown, therefore loud. Four mutations caught. Suite 692 -> 696. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by reading the trial machine's own digest minutes after 0.4.9 shipped.
v0.4.8 taught the tool that a loopback-only binding is a different claim from
*:4444— but wired that rule into theaddedpath only. An ssh local port-forward therefore reported aslistener ssh now ALSO on port(s) 127.0.0.1:8080at ORANGE, above the notify threshold, while the identical binding on a brand new process was YELLOW. Same binding, same reachability, two answers depending on whether the process happened to be in the baseline already.Now: a gained port that is loopback-only is YELLOW; one public port among loopback ones keeps the finding ORANGE; a bare port from a pre-0.4.8 snapshot remains unknown and therefore loud.
Four mutations run against the new tests — reverting the fix, swapping
allforany, and two that make an unknown binding count as local — all four fail the suite.Suite 692 → 696.
🤖 Generated with Claude Code