fix(repositories): declare doggy-countdown public so a reconcile cannot unpublish it - #124
Conversation
CI green at @coderabbitai review |
|
✅ Action performedReview finished.
|
📝 WalkthroughWalkthroughThe doggy-countdown Crossplane repository configuration now explicitly sets visibility to public while retaining its management policies. Its Kustomize resource entry was also moved within the repository resources list. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Readiness at
|
Why
doggy-countdownwas declared private when it was created, then made public once it became a published site. The declaration was never updated, so the config now says one thing and the repository is another.That matters more than it looks: the declared value is what a reconcile applies. Right now nothing applies it (#123), but the moment that is fixed, this file would take a live public site private — which is exactly the failure this PR exists to prevent, and exactly what #123 warns is already queued up for two other repositories.
What
Declares the repository public, and moves it out of the private grouping so the file reads the way it behaves.
The comment is corrected too. It previously claimed the pin existed "so management can never expose it" — the opposite of what is now wanted; it now says the pin exists so a reconcile can never take the published site private.
Declared and live now agree, so this repository is safe under either order of fixing #123.