Skip to content

fix(repositories): pin hasDownloads so reconciliation stops 422-ing #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devantler merged 1 commit into from
Jul 27, 2026
Merged

fix(repositories): pin hasDownloads so reconciliation stops 422-ing #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions deploy/repositories/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ resources:
# update PATCH gets 422 "Commit signoff is enforced ... and cannot be
# disabled"). The 12 already-adopted repos had this true via LateInitialize;
# pinning it here makes every repo's update self-consistent and robust.
# - hasDownloads: false — GitHub has removed the downloads feature and no
# longer returns the field, so status.atProvider never carries it. The
# Terraform provider still defaults it to true, so any repo whose spec picked
# that default up through LateInitialize holds a value the API can never
# report back. That is an unresolvable diff: the provider sees spec != live on
# every reconcile and issues an update PATCH forever. Those PATCHes are then
# rejected wholesale (422, on the commit-signoff field), so NO declared
# setting reaches GitHub for that repository — visibility included. Pinning
# the field to the value the API actually reflects is what stops the diff, and
# therefore what keeps the rest of this file enforceable.
patches:
- target:
group: repo.github.m.upbound.io
Expand Down Expand Up @@ -65,3 +75,6 @@ patches:
- op: add
path: /spec/forProvider/webCommitSignoffRequired
value: true
- op: add
path: /spec/forProvider/hasDownloads
value: false
Loading