Skip to content

chore(deps): update agent skills - #157

Merged
devantler merged 2 commits into
mainfrom
deps/agent-skills-update
Aug 24, 2026
Merged

chore(deps): update agent skills#157
devantler merged 2 commits into
mainfrom
deps/agent-skills-update

Conversation

@botantler-1

@botantler-1 botantler-1 Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Automated update of agent skills to their latest versions.

Updated files under plugins:

1 update(s) available:
  • portfolio-maintenance (devantler-tech/agent-skills) 6a63a7e6 > fbf1576c [v1.11.3]
Updated portfolio-maintenance
All skills are up to date.
All skills are up to date.
! Skipping github-actions-docs: could not resolve xixu-me/skills: could not determine default branch: HTTP 404: Not Found (https://api.github.com/repos/xixu-me/skills)
All skills are up to date.
All skills are up to date.
All skills are up to date.
All skills are up to date.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Programmed-bot classifier returns 3 at this head — a genuine marketplace update, so it is trusted and actionable but takes the normal semantic-review gate rather than the no-review carve-out. Requesting that review.

Static read of the substantive change (skills/portfolio-maintenance/SKILL.md, synced from agent-skills v1.9.5 → v1.11.3): it adds a resume-before-survey path, gated on four conjunctive prerequisites. Reviewed for authority boundaries, since this file is executable agent instruction that ships to every lane — and it reads as a net tightening:

  • the maintainer-instruction carve-out is narrowed to work the run can verify it created, rather than any trusted PR;
  • the ownership token must be renewed before each resumed mutation, with stand-down on a failed renewal, instead of once at the start;
  • advance-level work is excluded from resuming, so the ladder cannot be inverted;
  • the preemption checks (breakage, the full hygiene pentad, control channel, live re-verification) run on every run, resumed or not;
  • staleness is bounded at 4 hours, so discovery is delayed at most, never dropped.

No guardrail is weakened that I can find, and the one structural risk — a resumed run skipping discovery — is bounded by those checks plus the staleness bound.

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

@devantler I will review pull request #157.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 55126565-93f5-4f39-aa11-5096b1c7a239

📥 Commits

Reviewing files that changed from the base of the PR and between e730821 and 862b4da.

📒 Files selected for processing (5)
  • .claude-plugin/marketplace.json
  • .github/plugin/marketplace.json
  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • plugins/agentic-engineering/plugin.json
  • plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (3)
**/{.github/workflows,.github/plugin,.claude-plugin}/**/*.json

📄 CodeRabbit inference engine (AGENTS.md)

The two marketplace manifests are the contract

Files:

  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • .github/plugin/marketplace.json
  • .claude-plugin/marketplace.json
plugins/**/{plugin.json,.claude-plugin/plugin.json}

📄 CodeRabbit inference engine (AGENTS.md)

Keep both normalised JSON documents semantically identical

Files:

  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • plugins/agentic-engineering/plugin.json
plugins/**/skills/**/SKILL.md

📄 CodeRabbit inference engine (AGENTS.md)

plugins/**/skills/**/SKILL.md: Every bundled SKILL.md must validate against the
agentskills.io spec — CI validates each discovered skill in a matrix.

Files:

  • plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md
🧠 Learnings (2)
📚 Learning: 2026-07-25T12:40:46.973Z
Learnt from: devantler
Repo: devantler-tech/agent-plugins PR: 89
File: plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md:0-0
Timestamp: 2026-07-25T12:40:46.973Z
Learning: During code review in this repo: (1) For `plugins/agentic-engineering/agents/*.agent.md` (local agent-entrypoints), do NOT require upstream provenance frontmatter—assume these are authored locally; renames/edits to agent-entrypoints should remain local and not be forced through the upstream sync process. (2) For bundled skill artifacts at `plugins/*/skills/*/SKILL.md`, expect upstream provenance frontmatter to be present; do not make direct “local” edits for skill content—skill changes must originate from the upstream source and be brought in via the repo’s sync workflow.

Applied to files:

  • plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md
📚 Learning: 2026-06-28T12:17:58.373Z
Learnt from: devantler
Repo: devantler-tech/agent-plugins PR: 36
File: plugins/engineering-practices/skills/conventional-release/SKILL.md:57-59
Timestamp: 2026-06-28T12:17:58.373Z
Learning: Bundled skill artifact files at `plugins/*/skills/*/SKILL.md` are synced from upstream and must not be hand-edited locally. If you need to change a skill, update the corresponding upstream skill repository first, then pull the updated artifact into this repo using the `update-agent-skills` workflow (and review the resulting diff for the synced contents).

Applied to files:

  • plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md
🪛 LanguageTool
plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md

[style] ~123-~123: ‘lag behind’ might be wordy. Consider a shorter alternative.
Context: ...d review findings, a conflict with or lag behind the base, any pre-merge quality checks ...

(EN_WORDINESS_PREMIUM_LAG_BEHIND)


[style] ~129-~129: The adverb ‘never’ is usually put between ‘have’ and ‘been’.
Context: ...-published quality failure, or simply never have been reviewed at the commit it now carries, ...

(ADVERB_WORD_ORDER)

🪛 SkillSpector (2.5.1)
plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md

[error] 117: [P2] Hidden Instructions: Hidden instructions were detected in comments or invisible text. These could contain malicious directives. Manual review is recommended.

Remediation: Audit all comments and invisible characters. Remove any instructions that direct the agent to perform unauthorized actions. Use plain, reviewable content.

(Prompt Injection (P2))

🔇 Additional comments (5)
.claude-plugin/marketplace.json (1)

30-30: LGTM!

.github/plugin/marketplace.json (1)

30-30: LGTM!

plugins/agentic-engineering/.claude-plugin/plugin.json (1)

4-4: LGTM!

plugins/agentic-engineering/plugin.json (1)

4-4: LGTM!

plugins/agentic-engineering/skills/portfolio-maintenance/SKILL.md (1)

2-15: LGTM!

Also applies to: 58-167, 297-303


📝 Walkthrough

Walkthrough

The plugin manifests update agentic-engineering from version 4.4.9 to 4.4.10. The portfolio maintenance skill updates its metadata to v1.11.3. Its run loop now validates carry-forward state, artifact ownership, token renewal, preemption conditions, and survey freshness before resuming or running a full survey. Full surveys now persist the unfinished artifact and completion timestamp in memory.

Merge Risk: ⚪ Minimal · up to 862b4

This PR updates an agent skill and its package metadata without any identified merge-blocking correctness, security, availability, or deployment risk. It is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies an agent skills update, although it does not name the specific portfolio-maintenance skill.
Description check ✅ Passed The description directly explains the agent skill update, the portfolio-maintenance version change, and the skipped repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Merge readiness at 862b4da0e1

Review gate satisfied by CodeRabbit at this head. Head status CodeRabbit / success — Review completed, and the auto-generated summary comment was refreshed at 07:48:57Z (after the 07:45:57Z request) naming this head. Its only collapsed section is 🔇 Additional comments (5) — the informational one — and there are zero inline review comments and zero unresolved threads on a successful paginated read. So: a completed review with no actionable finding, not an absent one.

Behaviour observed, not inferred. Validate spec (plugins/agentic-engineering/skills/portfolio-maintenance) ran and passed at this exact head — that is the check which parses the one substantive file this pull request changes. Validate manifests, Discover skills and Check bundled skill edits also passed, covering the four manifest/version files. 41 check-runs in total (total_count read as the control against pagination), 39 success and 2 skipped, none failing.

Classifier result recorded: programmed-bot-review-exemption.sh exits 3 at this head — a genuine marketplace update from app/botantler-1, trusted and actionable, but explicitly not granted the no-review carve-out. It therefore took the ordinary semantic-review gate above rather than being waved through on provenance, and it is merged directly with the head pinned rather than by arming auto-merge, since that App's trust here is scoped to this classified commit.

Semantic review of skills/portfolio-maintenance/SKILL.md (v1.9.5 → v1.11.3) is recorded in the review request above: the resume-before-survey path narrows the maintainer-instruction carve-out to verified own work, requires token renewal before each resumed mutation with stand-down on failure, excludes advance work from resuming, keeps every preemption check on every run, and bounds staleness at 4 hours. Net tightening; no guardrail weakened.

@devantler
devantler merged commit c97645d into main Aug 24, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Aug 24, 2026
@devantler
devantler deleted the deps/agent-skills-update branch August 24, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant