docs: correct AGENTS.md CI-validation claim (ruleset injects validate-go-project)#99
Merged
Merged
Conversation
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
AGENTS.mdtwice claimed CI does not verify the scaffold:Both are inaccurate. CI genuinely builds/tests/lints the scaffold — and this exact wrong premise is what lured a prior run into filing #76 ("wire the shared validate-go-project workflow so CI actually verifies the scaffold"), which was closed as invalid: wiring it into
ci.yamlwould double-run every job because the workflow already runs via a repository ruleset.Ground truth (verified live, 2026-06-09)
A repository ruleset "Require workflows to pass before merging for Go" (active) injects
devantler-tech/reusable-workflows/.github/workflows/validate-go-project.yaml@mainon every PR + merge queue. On PR #98 the✅ Validate Go Projectworkflow ran (🔍 Detect Changes,🧹 Lint - mega-linter= SUCCESS;🏗️ Build/🧪 Test/golangci-lint/Dead Code/CoverageSKIPPED only because #98 was an actions-only bump — change-detection correctly gates the Go jobs to Go-touching PRs). The repo's ownci.yamlCI - Required Checksaggregator (emptyjob-results) is a separate, trivially-passing status check — not the Go gate.So the README (which advertises golangci-lint/MegaLinter/coverage "in CI") was right all along; only
AGENTS.mdcontradicted reality.Fix (docs-only, AGENTS.md only)
validate-go-project(build/test/golangci-lint/dead-code/MegaLinter/coverage), thatci.yamlis a separate trivially-passing aggregator, and an explicit don't wirevalidate-go-projectintoci.yaml(double-run; see ci: wire the shared validate-go-project workflow so CI actually verifies the scaffold #76 closed-invalid) note.No
ci.yaml/workflow change — this PR only makes the agent file match live CI, so a future agent reading it won't re-derive the #76 misstep.Why it matters
Agent/instruction files are a maintained product: a wrong one silently misleads every future agent and reviewer. This is a recurring trap (the #76 re-proposal premise) closed at the source.
Size: XS (docs-only).