fix: wire Testkube into the base controllers kustomization#48
Merged
Conversation
Testkube ships a complete, self-contained controller under k8s/bases/infrastructure/controllers/testkube/ (HelmRelease + HelmRepository + namespace + NetworkPolicy + CRDs + its own kustomization.yaml), but the base controllers kustomization never referenced it, so it rendered into zero clusters and the README's "Testkube (local/CI only; not deployed to prod)" was effectively false. Add `- testkube/` to k8s/bases/infrastructure/controllers/kustomization.yaml. The docker (local/CI) provider includes the whole base controllers dir, so it now deploys Testkube; the hetzner (prod) overlay enumerates base controllers explicitly and does not list testkube, so prod stays opted out — matching the README qualifier exactly. Fixes #47
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single line is added to ChangesTestkube Resource Registration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the maintainer's decision on #47 ("I decide to go with 1" — wire-in).
Problem
k8s/bases/infrastructure/controllers/testkube/is a complete, self-contained controller (HelmRelease + HelmRepository + namespace + NetworkPolicy + full CRD set + its ownkustomization.yaml), but the base controllers kustomization never referenced it. So Testkube rendered into zero clusters, and the README's**Testing** — Testkube _(local/CI only; not deployed to prod)_was effectively false.Change
One-line additive edit — add
- testkube/tok8s/bases/infrastructure/controllers/kustomization.yaml(placed alphabetically in thet…group).This routes exactly as the README intends:
- ../../../../bases/infrastructure/controllers/) → now deploys Testkube.testkube/, so prod stays opted out.Validation
kubectl kustomizebuilds clean and deterministic, with Testkube wired in local/CI only:testkuberesourcesk8s/providers/docker/.../controllers/(local/CI)k8s/providers/hetzner/.../controllers/(prod)k8s/bases/.../controllers/ksail workload validaterenders the rest of the tree fine. Two caveats, both pre-existing / not introduced by this change:oci://…/testkube:2.9.5) that ksail's renderer can't pull without a registry client, so the HelmRelease is validated as-is (a warning, not a failure). This is a Testkube chart-packaging quirk, independent of the wiring.ksail workload validateflakes non-deterministically on thebases/dockercontroller groups with YAML-corruption errors (could not find expected ':',mapping values are not allowed) — this is the known kubeconform#363 buffer-aliasing race (varying failure counts across identical runs;kubectl kustomizeis always clean). Thevalidate-scaffoldgate may therefore need a re-run; it does not indicate a defect in this change.Size
Small / additive / behaviour-preserving for prod (byte-identical hetzner output).
Fixes #47
Summary by CodeRabbit