fix(npm-packages): support namespaced packages like @org/pkg#110
Closed
ThePlenkov wants to merge 1 commit intodevcontainers-extra:mainfrom
Closed
fix(npm-packages): support namespaced packages like @org/pkg#110ThePlenkov wants to merge 1 commit intodevcontainers-extra:mainfrom
ThePlenkov wants to merge 1 commit intodevcontainers-extra:mainfrom
Conversation
koralowiec
added
the
existing feature
koralowiec
requested changes
Mar 4, 2025
Member
koralowiec
left a comment
koralowiec
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Before merging please bump the version of the feature, and update the test scenario, so it has a namespaced package there as well
Member
|
Addressed in #114, so I'm closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up on #104 I'd like to support globally installed packages with namespace