Skip to content

fix(npm-packages): support namespaced packages like @org/pkg #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThePlenkov wants to merge 1 commit into from
Closed

fix(npm-packages): support namespaced packages like @org/pkg #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/npm-packages/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ IFS=',' read -ra PACKAGE_ARRAY <<<"$PACKAGES"

# Iterate through each package
for package in "${PACKAGE_ARRAY[@]}"; do
# Check if package contains version
if [[ $package == *@* ]]; then
# Split package into name and version
name=${package%@*}
version=${package#*@}
# Use regex to split package into name and version
if [[ $package =~ ^(@?[^@]+)@(.+)$ ]]; then
name="${BASH_REMATCH[1]}"
version="${BASH_REMATCH[2]}"
else
# Package without version
name=$package
version=""
fi
Expand Down