Database saved-view와 편집 표현 책임을 정본화한다 - #587
Open
developer-1px wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
@interactive-os/json-document-editing의DatabaseTableView.projection하나로 통합합니다.DatabaseHand와Database.ViewToolbar가 같은DatabaseViewControls를, cell과 record panel이 같은DatabasePropertyControl을 소비합니다.DatabaseHandChange.updates로 remote patch를 전달하여 full-recordJSON.stringifydiff를 제거합니다.Closes #586
Goal Anchor
구조
축소 결과
-142 LOC-112 LOC검증
/demo/database: property edit, saved-view projection, 편집 전후 셀 크기 동일, 내부 이중 ring 없음, console error 없음재발 방지
DatabaseViewDocument병렬 model 금지JSON.stringifypatch 추론 금지