Fix bind example test#4
Merged
developit merged 1 commit intodevelopit:masterfrom Feb 1, 2017
bryanjenningz:patch-1
Merged
Conversation
The current bind example test will succeed even without using `@bind`. This is because of the way that `e.foo` is being called in the example test. When it is called like `e.foo()`, the `e` is to the left of the dot, so `e` is passed in as the `this` argument to the `foo` function. So the test `assert.equal(e.foo(), e)` will be `true` regardless of whether `@bind` is used. To fix this, we can change the test to `assert.equal(e.call(null), e)` to explicitly pass in `null` as the `this` argument for `foo` using `Function.prototype.call`.
Owner
|
Works for me! Easier than explaining the assignment problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current bind example test will succeed even without using
@bind. This is because of the way thate.foois being called in the example test. When it is called likee.foo(), theeis to the left of the dot, soeis passed in as thethisargument to thefoofunction. So the testassert.equal(e.foo(), e)will betrueregardless of whether@bindis used. To fix this, we can change the test toassert.equal(e.call(null), e)to explicitly pass innullas thethisargument forfoousingFunction.prototype.call.