Update lib structure#3
Closed
helderberto wants to merge 4 commits intodevelopit:masterfrom
helderberto:feature/update-structure-lib
Closed
Update lib structure#3helderberto wants to merge 4 commits intodevelopit:masterfrom helderberto:feature/update-structure-lib
helderberto wants to merge 4 commits intodevelopit:masterfrom
helderberto:feature/update-structure-lib
Conversation
update lib to ./src/histore.js update .gitignore prevent more files
Owner
|
I'm fine moving the library into |
Contributor
Author
|
Could u check again? :) |
|
@helderburato there is missing the empty end line, but previously it was there |
Contributor
Author
|
Fixed. Thanks @KnupMan! Could u review again @developit ? :) |
Owner
|
Still need to delete the package-lock.json: |
Contributor
Author
|
Done. @developit |
developit
approved these changes
May 12, 2018
Owner
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update package.json microbundle build folder ./src/*.js
update lib to ./src/histore.js
update .gitignore prevent more files