Fix some corner cases in the custom JSX parser and add tests #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #38 introduces a new custom parser implementing the complete JSX syntax. This pull request adds tests to some corner cases, and suggests fixes for them:
<a b="1" c />yielded the resulth('a', { b: '1' }). This can be fixed by switching to MODE_WHITESPACE when we encounter a whitespace (and after callingcommit()).out.replace(/,\(\{(.*?)$/, ',Object.assign({},{$1')gave unexpected results when there were multiple elements with spreads (because e.g."aba".replace(/a.*?$/, "x")returns"x") as well as attribute values containing the (sub)string,({. This can be fixed by separately keeping track of the generated property argument.