Same prevProps/nextProps as this.props passed to componentDidUpdate / shouldComponentUpdate for nested props

[dandv]

Repro:

import { h, Component } from 'preact';
import linkState from 'linkstate';

class Double extends Component {
  componentDidUpdate(prevProps, prevState) {
    console.log(prevProps.filter, this.props.filter);  // BUG: same
  }
  render() {
    return (
        <p>{this.props.filter.value * 2}</p>
    );
  }
}

export default class App extends Component {
  state = {
    filter: {
      value: 3
    }
  };
  render() {
    return (
      <div>
        <p>Change the number and watch the console. The filter values should be different but are identical.</p>
        <input type="number" onInput={linkState(this, 'filter.value')} />
        <Double filter={this.state.filter} />
      </div>
    );
  }
}

[developit]

@dandv is this fixed now that Preact 8.3.0 is released?

[dandv]

Will test, but I saw the bug while using linkState with React instead of Preact too.

[r1cs1]

Hi @developit @dandv,

[Edited: Sorry, messed it up first]

What do you think about this? Making the update immutable.

-Richard

return cache[key] || (cache[key] = function (e) {
        let t = e && e.target || this,
            state = {},
            obj = state,
            v = (t.type.match(/^che|rad/) ? t.checked : t.value),
            i = 0;

        for (; i < path.length - 1; i++) {
            obj[path[i]] = (obj[path[i]] && { ...obj[path[i]] }) || (obj[path[i]] = !i && { ...component.state[path[i]] } || {});
            obj = obj[path[i]];
        }
        obj[path[i]] = v ;

        component.setState(state);
    });