Add generic types and update tests #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@developit LMK what you think, thanks! |
* Add generic types to `on`, `off` and `emit` to enable some nicer TS usage if you specify what type you're expecting from the `EventData`. * Move the tests to be TypeScript source. This will help catch errors in the tests if there are any type errors. * Create a new test to test the generic types and make sure they pass and error when expected. * Upgrade to Mocha 8. * Did some tidying up of the package.json scripts.
jackfranklin
force-pushed
the
mochav8-and-typescript
branch
from
0bbd238 to
28fcc9e
Compare
Contributor
Author
|
@developit let me know if I can help do anything to help this ship, thanks! |
Owner
|
Will get to this today! |
developit
approved these changes
Jul 8, 2020
Owner
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
Looks good - only tiny nit is that I'd prefer to use a "mocha" package.json field, but I'm happy to do that post-merge.
Owner
|
Ah also some sneaky TS errors in the CI output. I think I have a fix in Codespaces, will check tomorrow morning. |
Owner
|
Shipped as 2.1.0, no longer a preview release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on,offandemitto enable some nicer TSusage if you specify what type you're expecting from the
EventData.the tests if there are any type errors.
and error when expected.