Skip to content

Not deleting attributes.className. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saboya wants to merge 2 commits into from
Closed

Not deleting attributes.className. #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a26c8bd
Not deleting attributes.className.
saboya Feb 27, 2017
8c922aa
Merge branch 'master' into className
saboya Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ function extend(base, props) {

function setClass(attributes, value, append) {
let cl = getClass(attributes);
if (attributes.className) delete attributes.className;
if (append) value = cl ? (cl + ' ' + value) : value;
Copy link
Owner

@developit developit Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will mess up rendering. Likely will render class twice (since its aliased)

Copy link
Contributor Author

@saboya saboya Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests, here's what happens (post-patch):

If only className is set, works as intended (class rendered once, correctly).
If only class is set, works as intended (class rendered once, correctly)
If both class and className are set, class is ignored and className is rendered correctly (as the class attribute).

Copy link
Owner

@developit developit Feb 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering if it overwrites preact-mdl's class modifications. I can set up a test if needed, could just be this test but with added class and className variants to verify that the MDL button classes still make it out to the DOM:
https://github.com/developit/preact-mdl/blob/master/test/index.js#L27

attributes.class = value;
}
Expand Down