Conversation
- separate rollup.config - rename todomvc copies - adjust npm scripts
Collaborator
Author
|
Unless |
Owner
|
|
Collaborator
Author
|
That's what I thought. Yup! |
Collaborator
Author
|
@developit This is your call (obviously 😜). Won't care if you trash it, but if you're waiting for me to merge it, I can't. |
Owner
|
Going to check it out locally so I can get acquainted with the dev workflow and check a couple things (sourcemaps etc) |
Owner
|
(sorry for taking an eternity on this, toiling over 7.2 release and some other stuff!) |
Collaborator
Author
|
Cool! No matter to me; can go either way. |
Collaborator
Author
|
Wow this is old 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Rollup, there is (currently) no way to both recompile changes and reload the current server. Forget about HMR! The Rollup dev process needs a third party to breach the gap & coordinate tasks.
This PR brings back the
webpack-dev-serverutility/behavior while still using Rollup.Changes:
http-serverwithbrowser-synctodomvc-*static assets.npm scriptsI could have used
fly-uglifyand re-applied the UglifyJS2 config using its JS API, but the previous CLI string was already done & straightforward, so I just passed it thrufly-shellinstead.