Skip to content

Conversation

@pluscubed
Copy link
Contributor

@pluscubed pluscubed commented Jul 11, 2017

In some rare cases (e.g. Object.create(null)), a prop value doesn't have the toString() function, and thus cannot be cast to a string, throwing TypeError: Cannot convert object to primitive value. This should fix that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d34c7f on plusCubed:master into 824404b on developit:master.

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@developit developit requested a review from NekR July 17, 2017 20:21
@developit
Copy link
Member

I've looped @NekR in since he wrote this. Looks good to me though.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00be0a1 on plusCubed:master into e026d9e on developit:master.

Copy link
Collaborator

@NekR NekR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants