Merged
Conversation
marvinhagemeister
changed the title
marvinhagemeister
force-pushed
the
ts_typings
branch
from
144e0e9 to
3d70162
Compare
marvinhagemeister
changed the title
developit
approved these changes
Dec 25, 2017
Owner
|
I think we need additional typings for the dedicated library builds too! |
|
Can we merge this? |
|
Why it's not merged yet? Without this commit, TypeScript broken. |
Closed
developit
approved these changes
May 5, 2018
Owner
|
Sorry all! Not sure how this fell through the cracks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the typings up to date with the current code in master.
Open tasks:
[ ] Typesafe integrationsEDIT: Decided it's better for now to simply fix the
createStoredefault export. The integrations seem to be picked up fine by the ts compiler.