Skip to content

Fix devtools reporting#64

Merged
developit merged 1 commit intodevelopit:masterfrom
bjrnt:patch-1
Jan 22, 2018
Merged

Fix devtools reporting#64
developit merged 1 commit intodevelopit:masterfrom
bjrnt:patch-1

Conversation

@bjrnt
Copy link
Copy Markdown
Contributor

@bjrnt bjrnt commented Jan 21, 2018

Hello! :)
Cool library - learnt a lot from reading the source code.

I noticed there's a small bug in the devtools in the following case:

  1. Actions are dispatched as normal
  2. The devtools are used to jump to a certain state, which causes ignoreState = true
  3. More actions are dispatched, but since ignoreState is still true, these do not get logged to the devtools

I fixed this by setting ignoreState back to false after the devtools action has been processed by the store.

@developit
Copy link
Copy Markdown
Owner

Makes sense to me! I'll ping @heldr who wrote the Devtools integration for his sign-off.

@heldr
Copy link
Copy Markdown
Contributor

heldr commented Jan 22, 2018

Just tested here.

LGTM! 🍵

@developit developit merged commit 2320a8a into developit:master Jan 22, 2018
@developit
Copy link
Copy Markdown
Owner

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants