Skip to content

Conversation

@QingWei-Li
Copy link
Contributor

Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
@xzilja
Copy link

xzilja commented Dec 7, 2019

I was just about to submit similar PR with added "name" field (will submit this pr once this lands). @developit it looks like failing ci is not related to the change / rather some package. Do you have any idea on what is causing it, I'd be up to submit commit to fix this, as this PR enables workerize loader to be used in next.js #80

@Poky85
Copy link

Poky85 commented Jan 19, 2020

Tested and confirm that publicPath option allows Next.js integration with following next.config.js:

module.exports =  {
  webpack: (config, params) => {
    config.module.rules.push({
      test: /\.worker\.(js|ts)$/,
      loader: 'workerize-loader',
      options: {
        name: 'static/[hash]',
        publicPath: '/_next/'
      },
    });
    config.output.globalObject = 'self';

    return config
  }
};

@developit
Copy link
Owner

Apologies for the super slow merge here! I'm fixing the CI, you're right about it being totally unrelated.

@xzilja
Copy link

xzilja commented Mar 4, 2020

@QingWei-Li any chance you could merge this please?

@QingWei-Li
Copy link
Contributor Author

@iljadaderko I'm not a maintainer. We need @developit to merge.

@mrdivyansh
Copy link

@developit any chance you could merge this please?

@developit developit merged commit 86cd7c0 into developit:master Jun 16, 2020
@developit
Copy link
Owner

Released in 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants