Add separate build for web target #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ack! I feel terrible I didn't see this before I fixed #95! I had originally tried to use |
Contributor
Author
|
@developit yeap, I was digging source of mircobundle a bit before this fix |
Contributor
Author
|
@developit so this commit a6423f7 seems to fix the problem |
Owner
|
Released in 1.3.0. |
Contributor
Author
|
Thank you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrade from 1.1.0 to 1.2.0/1.2.1 we noticed that workers stopped working in IE (arrow functions caused syntax error). It seems to be related to microbundle upgrade here
This commit just adds separate build with target 'web' so both 'rpc-wrapper.js' and 'rpc-worker-loader.js' can be executed without having syntax error in old environments.
I didn't find a better way than just adding another build command. Maybe there is a better way to do that with microbundle