fix: Don't use ThreadPoolExecutor in emscripten#1204
Merged
Conversation
kylebarron
added a commit
that referenced
this pull request
Jun 12, 2026
this should unblock the CI failure we currently have in #1206 , #1205 , #1204 Written by claude: --- ### Problem CI fails on 13 tests with `requests.exceptions.HTTPError: 403 Client Error: Forbidden` for `https://www.nyc.gov/assets/planning/download/zip/data-maps/open-data/nybb_16a.zip` — nyc.gov no longer serves the `nybb` test dataset. Local runs only pass when a warm `geodatasets` cache exists. ### Fix Bump `geodatasets` 2026.1.0 → 2026.5.1 in `uv.lock` (single-package upgrade, nothing else changes). The new release relocates the `nybb` download to `https://github.com/geopandas/geodatasets/raw/refs/heads/main/data_backup/nybb_16a.zip`. ### Verification With the geodatasets cache removed (simulating CI), `tests/test_map.py::test_default_view_state_inferred` and `tests/test_viz.py::test_viz_reproject` — both failing in CI — pass and download from the new URL: `2 passed`. This unblocks CI for #1205 and #1206, which should be rebased/rerun once this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #1203