feat: Add user-accessible APIs for managing shard index caching - #137
Merged
Conversation
kylebarron
marked this pull request as ready for review
August 4, 2026 21:16
Member
Author
|
@d-v-b I'm merging this to make it easier to iterate; but happy to make changes if you have feedback! |
Contributor
|
+1 to moving fast! my two questions after a cursory read -- how are nested subchunks handled, and what's the contract between an arbitrary array-bytes codec and the array that allows the array to use the cache? I assume there's a trait in zarrs for "contains subchunks". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
ShardCacheandAsyncShardCache. These map to the upstreamArrayShardedReadableExtCacheandAsyncArrayShardedReadableExtCache, which are required arguments when reading sharded data.Todo:
Arrayobjects I don't think. We'll improve this validation when we implement array equality.Closes #125