Skip to content

Reject unknown MCP tool arguments before dispatch#148

Merged
deverman merged 1 commit into
masterfrom
agent/143-reject-unknown-mcp-arguments
Jul 23, 2026
Merged

Reject unknown MCP tool arguments before dispatch#148
deverman merged 1 commit into
masterfrom
agent/143-reject-unknown-mcp-arguments

Conversation

@deverman

Copy link
Copy Markdown
Owner

Closes #143

Acceptance journey

A client that sends top-level list_tasks.search receives list_tasks.search is unsupported; use list_tasks.filter.search before FocusRelay queries OmniFocus. Unknown nested query and mutation properties likewise fail with their complete argument path.

Validation impact

server-wire

Changes

  • derive runtime unknown-property validation from the same schemas returned by tools/list
  • recursively close every object schema with additionalProperties: false
  • validate before query or mutation dispatch
  • add direct JSON-RPC wire coverage for both observed OpenCode payloads plus nested filter, page, and mutation properties
  • document the fail-closed MCP boundary

Validation

  • swift run focusrelay-dev validate --impact server-wire — 162 tests passed and production build succeeded
  • direct wire regression confirms malformed mutation arguments return before performMutation / Bridge dispatch

@deverman
deverman merged commit 81cf256 into master Jul 23, 2026
4 checks passed
@deverman
deverman deleted the agent/143-reject-unknown-mcp-arguments branch July 23, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject unknown or misplaced MCP tool arguments at the server boundary

1 participant