Skip to content

fix: add NetworkPolicy RBAC permissions - #1690

Draft
rohanKanojia wants to merge 1 commit into
devfile:mainfrom
rohankanojia-forks:fix/add-networkpolicies-rbac
Draft

fix: add NetworkPolicy RBAC permissions#1690
rohanKanojia wants to merge 1 commit into
devfile:mainfrom
rohankanojia-forks:fix/add-networkpolicies-rbac

Conversation

@rohanKanojia

Copy link
Copy Markdown
Member

What does this PR do?

Add kubebuilder RBAC for networking.k8s.io/networkpolicies (create, delete, update, patch, get, list, watch) on the DevWorkspaceRouting controller.

What issues does this PR fix or reference?

Operators are expected to be able to manage NetworkPolicy resources for their operands. The CSV currently only requests networking.k8s.io/ingresses.

Is it tested? How?

  • Marker-only change in this PR; generated RBAC/CSV updates come from make generate_all (include those manifests in this PR or a follow-up commit before merge).
  • Target branch: 0.43.x (also needed on main if not cherry-picked later).

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ed5f9904-b595-4b41-9bff-c5114f3fecb1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
rohanKanojia force-pushed the fix/add-networkpolicies-rbac branch from 47a5b81 to 0a27c97 Compare August 10, 2026 18:09
@rohanKanojia rohanKanojia changed the title docs: create DWO 0.43.0 changelog fix: add NetworkPolicy RBAC permissions Aug 10, 2026
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
rohanKanojia force-pushed the fix/add-networkpolicies-rbac branch from 0a27c97 to ac6c2b2 Compare August 10, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant