dmtest: Write random data instead of zeroes to geometry block - #3
Merged
Merged
Conversation
bmarzins
reviewed
Apr 25, 2026
Replaces the function that write zeroes to the vdo geometry block with a call to write random data. Then checks for possible expected error messages. The new code that formats vdo devices directly in the kernel decides whether to format by looking at the geometry block. If it is all zeroes, the device is formatted. Therefore, we want to change this test to write random data instead of zeroes, since we don't want to format the device. Signed-off-by: Bruce Johnston <bjohnsto@redhat.com>
bjohnsto
force-pushed
the
fix_corrupt_vdo
branch
from
April 27, 2026 15:03
82a31f5 to
faa8bc6
Compare
lorelei-sakai
approved these changes
Apr 27, 2026
lorelei-sakai
left a comment
lorelei-sakai
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me; pretty much just the same as the earlier version so I guess cherry-picking worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the function that write zeroes to the vdo geometry block with a call to write random data. Then it checks for possible expected error messages.
The new code that formats vdo devices directly in the kernel decides whether to format by looking at the geometry block. If it is all zeroes, the device is formatted. Therefore, we want to change this test to write random data instead of zeroes, since we don't want to format the device.