Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 248 248
Lines 49961 49995 +34
Branches 4399 4401 +2
=======================================
+ Hits 46040 46072 +32
- Misses 3211 3213 +2
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
tens-deriv-kw
branch
3 times, most recently
from
32cc14d to
fcf95ab
Compare
FabioLuporini
left a comment
FabioLuporini
left a comment
There was a problem hiding this comment.
Uncontroverisal
PS: I just noted applyfunc should probably be a private meth
It's a sympy method from the sympy matrix type, not ours. |
mloubout
force-pushed
the
tens-deriv-kw
branch
3 times, most recently
from
aea705d to
abcb8d1
Compare
EdCaunt
left a comment
EdCaunt
left a comment
There was a problem hiding this comment.
A couple super tiny nitpicks, feel free to ignore. Looks g2g otherwise
tests/test_derivatives.py
Outdated
| u = Function(name="u", grid=grid, space_order=2, staggered=x) | ||
| v = Function(name="v", grid=grid, space_order=2, staggered=NODE) | ||
|
|
||
| w = [-2, 2] # Should 4 coeff since this is staggered |
tests/test_derivatives.py
Outdated
|
|
||
| eq0 = Eq(u, v.dx(w=w)).evaluate | ||
| exp0 = -2 * v / x.spacing + 2 * v._subs(x, x + x.spacing)/x.spacing | ||
| # This one should fallback to taylor coeffs sinc w is too short |
tests/test_tensors.py
Outdated
| f = func(name="t", grid=grid, space_order=2) | ||
|
|
||
| # Custom coefficients | ||
| c = [10, 10, 10] |
There was a problem hiding this comment.
Nitpick: is it worth making these 10, 20, 30 just to remove a potential non-uniqueness?
mloubout
force-pushed
the
tens-deriv-kw
branch
from
abcb8d1 to
af0bd23
Compare
3 participants
Fixes #2721