Skip to content

mpi: fix halo ispace with subdomains#2908

Merged
FabioLuporini merged 1 commit into
mainfrom
fix-halo-ispace
May 4, 2026
Merged

mpi: fix halo ispace with subdomains#2908
FabioLuporini merged 1 commit into
mainfrom
fix-halo-ispace

Conversation

@mloubout
Copy link
Copy Markdown
Contributor

@mloubout mloubout commented May 1, 2026

No description provided.

@mloubout mloubout added the MPI mpi-related label May 1, 2026
@mloubout mloubout force-pushed the fix-halo-ispace branch from 5ac9ccc to bed4842 Compare May 1, 2026 14:05
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (3539fd4) to head (fe15a66).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_subdomains.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   83.40%   83.37%   -0.04%     
==========================================
  Files         248      248              
  Lines       51647    51662      +15     
  Branches     4459     4459              
==========================================
- Hits        43075    43071       -4     
- Misses       7818     7835      +17     
- Partials      754      756       +2     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.70% <100.00%> (ø)
pytest-gpu-gcc- 77.98% <18.75%> (-0.04%) ⬇️
pytest-gpu-icx- 77.61% <18.75%> (-0.01%) ⬇️
pytest-gpu-nvc-nvidiaX 69.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test?

@FabioLuporini
Copy link
Copy Markdown
Contributor

Patch is good, but we need a test

@mloubout mloubout force-pushed the fix-halo-ispace branch from bed4842 to fe15a66 Compare May 4, 2026 03:55
@FabioLuporini FabioLuporini merged commit 931e137 into main May 4, 2026
42 checks passed
@FabioLuporini FabioLuporini deleted the fix-halo-ispace branch May 4, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MPI mpi-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants