Conversation
As SIZE_MAX exists in C99 Assisted-by: Stefan Eissing Assisted-by: Jay Satiro Ref: curl#18406 Closes curl#18426
Perl got bumped from 5.38.4 to 5.40.3. The new version crashes when loading the `Win32::Process*` modules built and cached in CI. The build job uses Perl 5.38.4. To avoid the crash, include the Perl version (hashed) in the cache key, so that it's only loaded when the Perl version matches. This solution is imperfect, because some of the jobs will not use the Perl modules in transition periods, when different jobs use different Perl versions. Anyway, can't think of a better one for now. Another option is to drop the effort with these modules. After all they did not help with crashes and hangs, nor with performance. While adding quite a bit of CI complexity. Also: - test early if the modules load and log the result. Follow-up to 52775a7 curl#18296 Closes curl#18425
Default timeout is hardcoded (10 seconds) and doesn't respect --connect-timeout parameter. In some cases 10 seconds can be not enough or too long to "establish a connection". Moreover the non-working --connect-timeout parameter for http3 is confusing. This change makes the handshake timeout equal to --connect-timeout, if it's set. Discussion is here curl#18427 Closes curl#18431
Handle errors returned by the callback the same for 0-length writes as for all the others. Closes curl#18428
To have it included by the time checking for `SIZE_MAX` and `SSIZE_MAX`. Ref: 93f333c curl#18426 curl#18406 Closes curl#18430
- using {} with single entries makes little sense
- when using {} sets with two entry lists, there can only be 64 to reach
maximum number of URLs
Verify the max check in test 761
https://github.com/msys2/setup-msys2/releases/tag/v2.29.0 Includes perl 5.40.3. Ref: 5bb49a4 curl#18425 Closes curl#18438
In some configs they happen Closes curl#18441
This allows --remote-time to set dates before 1970. Due to a minor omission in the API, it will still avoid setting the time if it is indeed exactly epoch 0 (jan 1 1970). Verified by test 762 Fixes curl#18424 Reported-by: Terence Eden Closes curl#18443
To avoid having to alloc or manage it separately. Closes curl#18442
Instead of checking it runtime. CodeSonar pointed out that if it actually CAN legitimately be NULL here, then we need to do more checks for it... Closes curl#18440
This was already done when building using CMake: https://github.com/curl/curl/blob/fa9151b41ad986e0514d99dd3fe149f26a7a57a3/CMakeLists.txt#L2391-L2394 Closes curl#18433
test_10_08, uploading larger files for a h2 proxy, sporadically fails with a decrpytion error on received data in AWS-LC. The frequency can be increased by simulated network receive blocks. Not setting a 4 * TLS record sized buffer, leaving AWS-LC at its default buffer size seems to mitigate this problem. Closes curl#18434
The libcurl API for CURLINFO_FILETIME_T clearly says it contains -1 if not set. Everything else is a valid time stamp so use that. Follow-up to 54f1ef0 Closes curl#18446
Only -1 means bad value, all others are acceptable. Ref: curl#18424 Closes curl#18447
Split out adding of individual request headers into a switch. Check the connection http version only on fresh connections, use separate methods. Add TE: header directly without allocation. Add bit for indicating Connection: header has been added and custom headers should not do that again. Closes curl#18444
By returning error separately on parse errors and avoiding magic numbers, this function can now return 0 or -1 as proper dates when such a date string is provided. Closes curl#18445
This allows IDEs that support this standard to automatically use the correct formatting options. Closes curl#18409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.