feat: deny-by-default permission handlers on service sessions#52
Merged
Conversation
devlargs
force-pushed
the
feat/session-permission-handler
branch
from
July 12, 2026 03:48
444320e to
b7d91f0
Compare
Service views load arbitrary third-party sites; Electron's default grants permission requests (camera, mic, geolocation, clipboard read, ...) without prompting. Install request+check handlers per service session: - allow notifications, fullscreen, sanitized clipboard write everywhere - additionally allow media (camera/mic) for Messenger/Facebook/WhatsApp hosts so calls keep working - deny everything else Fixes #42
devlargs
force-pushed
the
feat/session-permission-handler
branch
from
July 12, 2026 03:51
b7d91f0 to
b619512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Service views load arbitrary third-party sites, and Electron's default grants permission requests (camera, mic, geolocation, clipboard read, ...) without prompting. This installs
setPermissionRequestHandler+setPermissionCheckHandlerper service session:notifications,fullscreen,clipboard-sanitized-writeeverywheremedia(camera/mic) on messenger.com / facebook.com / whatsapp.com so calls keep workingHandler installation is idempotent per session, so view recreation is safe. Link previews share the service partition and inherit the same policy.
Note for review: if some service legitimately needs another permission (e.g. Discord screen share), the allowlist is the single place to extend — could later become a per-service setting.