Skip to content

Implemented schematron <value-of select="..."/>.#3

Merged
kzu merged 3 commits intodevlooped:masterfrom
nverwer:master
Jun 5, 2016
Merged

Implemented schematron <value-of select="..."/>.#3
kzu merged 3 commits intodevlooped:masterfrom
nverwer:master

Conversation

@nverwer
Copy link
Copy Markdown
Contributor

@nverwer nverwer commented Jun 3, 2016

Also:
Moved message formatting into FormatterBase class.
Added error message for abstract rules that are not found.

Message formatting still uses regular expressions instead of the XML structure.

Moved message formatting into FormatterBase class.
Added error message for abstract rules that are not found.
@kzu
Copy link
Copy Markdown
Member

kzu commented Jun 3, 2016

Heya, thanks for this!

I've just uploaded a .editorconfig that should make things easier to keep consistent (formatting-wise) and easier to review. Please install the EditorConfig extension in VS and that should be all you need to do to get the right tabs/spaces.

Also, could you add some unit tests that verify the new behavior? They typically are very useful to also figure out what is implemented and how it works in practice ;)

Thanks!

@nverwer
Copy link
Copy Markdown
Contributor Author

nverwer commented Jun 3, 2016

Hello Daniel,

I will have a look at the layout and add some unit tests soon.

@kzu
Copy link
Copy Markdown
Member

kzu commented Jun 3, 2016

Great!

On Fri, Jun 3, 2016, 10:33 AM Nico Verwer notifications@github.com wrote:

Hello Daniel,

I will have a look at the layout and add some unit tests soon.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAKW6-uhZZq_6bWOOSdQaeYCkfSXI-MXks5qIC1AgaJpZM4ItWqD
.

</ProjectReference>
</ItemGroup>
<ItemGroup>
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this makes the project into a unit testable project.

@nverwer
Copy link
Copy Markdown
Contributor Author

nverwer commented Jun 5, 2016

I hope that the lay-out is okay now. There is a unit test now.

@kzu kzu merged commit ab273c6 into devlooped:master Jun 5, 2016
@kzu
Copy link
Copy Markdown
Member

kzu commented Jun 5, 2016

Looks great, thanks!

@devlooped devlooped locked and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants