Implemented schematron <value-of select="..."/>.#3
Conversation
Moved message formatting into FormatterBase class. Added error message for abstract rules that are not found.
|
Heya, thanks for this! I've just uploaded a .editorconfig that should make things easier to keep consistent (formatting-wise) and easier to review. Please install the EditorConfig extension in VS and that should be all you need to do to get the right tabs/spaces. Also, could you add some unit tests that verify the new behavior? They typically are very useful to also figure out what is implemented and how it works in practice ;) Thanks! |
|
Hello Daniel, I will have a look at the layout and add some unit tests soon. |
|
Great! On Fri, Jun 3, 2016, 10:33 AM Nico Verwer notifications@github.com wrote:
|
| </ProjectReference> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> |
There was a problem hiding this comment.
Apparently, this makes the project into a unit testable project.
|
I hope that the lay-out is okay now. There is a unit test now. |
|
Looks great, thanks! |
Also:
Moved message formatting into FormatterBase class.
Added error message for abstract rules that are not found.
Message formatting still uses regular expressions instead of the XML structure.