Improve feature filter naming to avoid potential collisions#133
Merged
Conversation
A filter simply named "FeatureFilter" as an alias might collide with consumers that also use filters for their own functionality. So we make it more unique. Also, since leveraging feature flags is something we use as an internal implementation detail, we make the FeatureFlags enum internal instead, since it's not intended for public consumption.
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.17 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filter simply named "FeatureFilter" as an alias might collide with consumers that also use filters for their own functionality.
So we make it more unique.
Also, since leveraging feature flags is something we use as an internal implementation detail, we make the FeatureFlags enum internal instead, since it's not intended for public consumption.