Model ConversationId as an extension property instead#233
Merged
Conversation
The concept of a conversation id is not built-in WhatsApp, and therefore we should not force it on the basic API. It's rather a concept we implement specifically as part of the conversation storage and handler, which are entirely optional. With extension properties, we can make it seamless to use yet not tied to the core interfaces, since we support AdditionalProperties to support precisely this kind of extensibility scenarios.
kzu
force-pushed
the
dev/ConversationIdExtension
branch
from
e2df0d4 to
efd626a
Compare
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.18 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concept of a conversation id is not built-in WhatsApp, and therefore we should not force it on the basic API.
It's rather a concept we implement specifically as part of the conversation storage and handler, which are entirely optional.
With extension properties, we can make it seamless to use yet not tied to the core interfaces, since we support AdditionalProperties to support precisely this kind of extensibility scenarios.