Skip to content

Add support for VS Build Tools and VS Test Agent#46

Merged
kzu merged 11 commits intodevlooped:mainfrom
likemike91:main
Nov 4, 2020
Merged

Add support for VS Build Tools and VS Test Agent#46
kzu merged 11 commits intodevlooped:mainfrom
likemike91:main

Conversation

@likemike91
Copy link
Copy Markdown
Contributor

This PR adds support for the Visual Studio Build Tools and the Visual Studio Test Agent and therefore implements #44 .

Copy link
Copy Markdown
Member

@kzu kzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor changes, this looks good, thanks for looking into it!

Comment thread VisualStudio/InstallerService.cs Outdated
Comment thread VisualStudio/InstallerService.cs Outdated
Comment thread VisualStudio/Options/SkuOption.cs Outdated
@kzu
Copy link
Copy Markdown
Member

kzu commented Nov 2, 2020

Also, if you rebase on main, the build error from the push step will be gone 👍

@likemike91
Copy link
Copy Markdown
Contributor Author

Also, if you rebase on main, the build error from the push step will be gone 👍

I merged upstream but unfortunately forgot to rebase 🙈

@likemike91
Copy link
Copy Markdown
Contributor Author

@kzu I fixed the failing tests. Unfortunately my Visual Studio has shown me the tests all green so I thought everything is fine but in reality it didn't even run the tests.
Should be fine now.

@likemike91 likemike91 requested a review from kzu November 3, 2020 20:45
@kzu
Copy link
Copy Markdown
Member

kzu commented Nov 4, 2020

Thanks a lot for your contribution! Would be great to add a bit to the readme, if you can. But I'm willing to merge it as-is since the CLI help would already include a way to discover this new feature.

Thanks again!

@likemike91
Copy link
Copy Markdown
Contributor Author

@kzu I also updated the README now. Feel free to merge ;)

@kzu
Copy link
Copy Markdown
Member

kzu commented Nov 4, 2020

Hm, the rendering of the tables is broken: https://github.com/likemike91/dotnet-vs

image

@kzu
Copy link
Copy Markdown
Member

kzu commented Nov 4, 2020

Ah, you're missing some escapes for the |

@likemike91
Copy link
Copy Markdown
Contributor Author

Ah, you're missing some escapes for the |

Thanks for the hint...
Now everything should be fine. 👍

@kzu kzu merged commit 9dbd400 into devlooped:main Nov 4, 2020
@kzu
Copy link
Copy Markdown
Member

kzu commented Nov 4, 2020

Thanks a lot for your contribution @likemike91! 🤟

@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants