Fix worker.ts transformers.js API misuse + add comprehensive E2E tests - #57
Merged
Merged
Conversation
devlux76
marked this pull request as ready for review
March 20, 2026 08:11
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot
AI
changed the title
[WIP] Implement complete E2E testing for transformers.js
Fix worker.ts transformers.js API misuse + add comprehensive E2E tests
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker was using the transformers.js API incorrectly: passing
output_hidden_statesto a text-generation pipeline and expectingoutput.hidden_statesback — butTextGenerationPipeline._call()returns decoded text (TextGenerationSingle[]), not model outputs. Themodel.generate()loop in transformers.js v3 also never collects hidden states even if the config option is set, so the extraction was silently a no-op.Bug fixes (
src/worker.ts)PipelineCallable: wasGenerationOutput { hidden_states?: TensorLike[][] }— changed toTextGenerationSingle[]matching the actual APIoutput_hidden_statesfromGenerationCallOptions— it has no effect in the transformers.js v3 generate loopoutput.hidden_stateswas alwaysundefined, silently logging warnings every requestTextGenerationSingleinterface and a comment explaining the correct path to hidden states (pipe.model.forward()+ ONNX model exported with per-layer outputs)Before (wrong):
After (correct):
New E2E tests (
test/worker.e2e.test.ts)Uses
vi.hoisted+vi.mock('@huggingface/transformers')and aself.postMessageshim (required because jsdom treatspostMessage(data, [])aswindow.postMessagewith an invalid targetOrigin) to test the full worker message flow without downloading models.Covers:
pipeline()called with correcttask,modelId,dtype, anddeviceTextStreamer.callback_functiondo_sample: falseat temperature=0,do_sample: trueotherwiseTextGenerationSingle[]— nohidden_statesInterruptableStoppingCriteria→donenoterrorprogressmessageserrormessageOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.