nightly build not executing tests anymore

[hohwille]

We discovered by accident that our nightly build is not running our JUnit tests anymore.
All executions of maven skip the tests:

• IDEasy/.github/workflows/nightly-build.yml

  Line 31 in dbc533c

  mvn -B -ntp -Pnative -DskipTests=true -Drevision=${current_version} package

• IDEasy/.github/workflows/nightly-build.yml

  Line 84 in dbc533c

  run: mvn --settings .mvn/settings.xml -DskipTests=true -Darchetype.test.skip=true -Dgpg.skip=true -Dstyle.color=always -B -ntp -Passembly,msi,deploy deploy

Further, the step Download natives and build project only downloads artifacts but does not build the project:

IDEasy/.github/workflows/nightly-build.yml

Line 76 in dbc533c

- name: Download natives and build project

The assumption is that that step once was containing the build and test execution.

For the QA of the main branch we still have a separate CI build that runs the tests so we still see if main is red or green according to our tests so this is not critical.
Maybe we should even consider this as a feature and to avoid waste of resources.
However, at least renaming the build step removing and build project to avoid confusion should be the least done before closing this issue.

[samuelkos17]

I've looked at the last nightly build logs and it seems like the Download natives and build project does build the project, however the tests are indeed skipped. But since we have the seperate CI build that runs our tests (as mentioned above) we could close this issue now

[hohwille]

I've looked at the last nightly build logs and it seems like the Download natives and build project does build the project, however the tests are indeed skipped. But since we have the seperate CI build that runs our tests (as mentioned above) we could close this issue now

Indeed the 2nd aspect with "Download natives and build project" is already solved or obsolete.
Still it is best-practice to have smaller steps (avoiding steps named "A and B" but have Step "A" and separate Step "B" what also makes it easier to search logs and find what you are looking for if you do not mix too multiple aspects in one step) as we just have cleaned up with #2141.

IMHO the thought of the 1st aspect was that maybe we have OS specific issues where some JUnit may fail only on Windows or Mac and if we do not test this on GitHub we might miss out problems (e.g. if a Mac developer wants to build IDEasy and then tests are red on main this is not a good state and he would stop considering a contribution).
However, there is also a balance with sustainability and the duration of the release process.
So I would currently not consider to run the tests during the native image build.
The JUnits will be executed in the release build at the end before we publish anything (deploy, push, etc.) so the workflow will fail without any external side-effect. This will only run tests on Linux - but we have the same also for the CI build on main and for the PR build.
On Windows we have the developers working usually so Windows specific test failures will be revealed anyhow and with the new harness that can be activated as commit hook, there is no bypassing, once activated.
For Mac we also have some developers in our team and sooner or later such an edge-case would also be revealed.
So I would drop this demand.

Conclusion is that we can close this issue but lets first discuss if we want to create a little story splitting the workflow step into smaller steps.