Skip to content

#1829: fix problem I caused from review suggestion - #1861

Merged
hohwille merged 1 commit into
devonfw:mainfrom
hohwille:feature/1829-fix-pr-review-suggestion-problem
Apr 27, 2026
Merged

#1829: fix problem I caused from review suggestion#1861
hohwille merged 1 commit into
devonfw:mainfrom
hohwille:feature/1829-fix-pr-review-suggestion-problem

Conversation

@hohwille

@hohwille hohwille commented Apr 27, 2026

Copy link
Copy Markdown
Member

This PR fixes a small problem caused from review suggestion I did in PR #1829

Implemented changes:

  • provide URI from url also in case of an error.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2026.05.001 milestone Apr 27, 2026
@hohwille hohwille added urls ide-urls repo and related processes and features internal Nothing to be added to CHANGELOG, only internal story labels Apr 27, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 27, 2026
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Apr 27, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24991035602

Coverage decreased (-0.005%) to 70.636%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 21 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

21 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java 21 82.99%

Coverage Stats

Coverage Status
Relevant Lines: 15331
Covered Lines: 11284
Line Coverage: 73.6%
Relevant Branches: 6846
Covered Branches: 4381
Branch Coverage: 63.99%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@hohwille
hohwille merged commit e8d3835 into devonfw:main Apr 27, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Team Review to ✅ Done in IDEasy board Apr 27, 2026
@hohwille hohwille added the QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. label May 12, 2026
@hohwille hohwille self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. urls ide-urls repo and related processes and features

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants