Skip to content

#1849: Add support for VSCodium#1888

Open
laert-ll wants to merge 9 commits intodevonfw:mainfrom
laert-ll:feature/1849-support-vscodium
Open

#1849: Add support for VSCodium#1888
laert-ll wants to merge 9 commits intodevonfw:mainfrom
laert-ll:feature/1849-support-vscodium

Conversation

@laert-ll
Copy link
Copy Markdown
Contributor

@laert-ll laert-ll commented May 4, 2026

This PR fixes #1849

Implemented changes:

  • Added VSCodium as alternative edition to VSCode
  • Adjusted plugin installation error logging due to mismatch between VSCode & VSCodium plugins
  • Added test cases for implemented changes

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 4, 2026
@laert-ll laert-ll self-assigned this May 4, 2026
@laert-ll laert-ll moved this to 🏗 In progress in IDEasy board May 4, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 4, 2026

Coverage Report for CI Build 25364623040

Coverage decreased (-0.03%) to 70.631%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 27 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

27 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 13 0.0%
com/devonfw/tools/ide/tool/vscode/Vscode.java 12 65.63%
com/devonfw/tools/ide/context/IdeContext.java 2 76.19%

Coverage Stats

Coverage Status
Relevant Lines: 15397
Covered Lines: 11335
Line Coverage: 73.62%
Relevant Branches: 6878
Covered Branches: 4398
Branch Coverage: 63.94%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@laert-ll laert-ll force-pushed the feature/1849-support-vscodium branch from 7561315 to 24015b6 Compare May 5, 2026 06:20
@laert-ll laert-ll marked this pull request as ready for review May 5, 2026 08:15
@hohwille hohwille moved this from 🏗 In progress to Team Review in IDEasy board May 5, 2026
@AdemZarrouki AdemZarrouki self-requested a review May 5, 2026 12:05
@AdemZarrouki
Copy link
Copy Markdown
Contributor

I think we should add VSCodium to the table of tools in LICENSE.asciidoc as it has a different license (see https://github.com/VSCodium/vscodium/blob/master/LICENSE).

Also we need to add the tool to both Help.properties and Help_de.properties

Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving vscodium to a seperate folder and not puting it together with vscode to improve readability but its not a must. Maybe @hohwille can suggest if this is needed here or not. Otherwise, everything is fine from my point of view.
Nice job @laert-ll

@AdemZarrouki
Copy link
Copy Markdown
Contributor

AdemZarrouki commented May 5, 2026

Also i think we are missing tests for the VSCodium. Maybe something like https://github.com/devonfw/IDEasy/blob/main/cli/src/test/java/com/devonfw/tools/ide/tool/vscode/VscodeTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Support VSCodium

4 participants