Skip to content

#2181: Merge VSCodium plugins folder to VSCode#2195

Open
samuelkos17 wants to merge 3 commits into
devonfw:mainfrom
samuelkos17:feature/2181-merge-vscodium-plugins-folder-to-vscode
Open

#2181: Merge VSCodium plugins folder to VSCode#2195
samuelkos17 wants to merge 3 commits into
devonfw:mainfrom
samuelkos17:feature/2181-merge-vscodium-plugins-folder-to-vscode

Conversation

@samuelkos17

@samuelkos17 samuelkos17 commented Jul 21, 2026

Copy link
Copy Markdown

This PR fixes #2181

Implemented changes:

  • Added a new property excluded-editions in the .properties of plugins that can be set with a list of comma-separated names of versions of IDEs. To make this change future-proof the filter for the new property is implemented in the installPlugins()-method of the PluginBasedCommandlet-class. This means that it can be used for other IDEs besides VSCode and VSCodium.
  • Added a new field excludedEditions to the ToolPluginDescriptor-record matching the new property of the plugins
  • "Removed" the getPluginsConfigPath()-method of the Vscode-class so that both VSCodium and VSCode share the same folder for the plugins. However to guarantee backward-compatibility, the method can optionally be changed so that if 'settings/vscodium/plugins/' exists and 'settings/vscode/plugings/' has no VSCodium-specific overrides the plugins in VSCodium directory are installed instead.
  • Added tests in VscodeTest.java.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run the new tests in 'VscodeTest.java'

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@CLAassistant

CLAassistant commented Jul 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coveralls

coveralls commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30072174238

Coverage increased (+0.03%) to 72.588%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 19 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

19 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java 10 86.98%
com/devonfw/tools/ide/tool/plugin/ToolPluginDescriptor.java 4 86.89%
com/devonfw/tools/ide/tool/vscode/Vscode.java 4 84.62%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 16967
Covered Lines: 12839
Line Coverage: 75.67%
Relevant Branches: 7588
Covered Branches: 4985
Branch Coverage: 65.7%
Branches in Coverage %: Yes
Coverage Strength: 3.2 hits per line

💛 - Coveralls

@samuelkos17 samuelkos17 self-assigned this Jul 21, 2026
@samuelkos17 samuelkos17 added enhancement New feature or request vscode Microsoft visual studio code settings ide-settings repo and replated processes and features plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) labels Jul 21, 2026
@samuelkos17 samuelkos17 moved this from 🆕 New to 🏗 In progress in IDEasy board Jul 21, 2026
@samuelkos17 samuelkos17 moved this from 🏗 In progress to Team Review in IDEasy board Jul 21, 2026
@laert-ll laert-ll self-assigned this Jul 21, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelkos17 just as a first quick feedback while this is still in team review:
I very much like your idea of the excluded-editions property as CSV.
This is a very generic solution idea that can be useful for any kind of IDE and perfectly helps us for the current use-case to exclude some plugins from VSCodium. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) settings ide-settings repo and replated processes and features vscode Microsoft visual studio code

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Merge VSCodium plugins folder to VSCode

5 participants