#2181: Merge VSCodium plugins folder to VSCode#2195
Open
samuelkos17 wants to merge 3 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 30072174238Coverage increased (+0.03%) to 72.588%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions19 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
hohwille
reviewed
Jul 21, 2026
hohwille
left a comment
Member
There was a problem hiding this comment.
@samuelkos17 just as a first quick feedback while this is still in team review:
I very much like your idea of the excluded-editions property as CSV.
This is a very generic solution idea that can be useful for any kind of IDE and perfectly helps us for the current use-case to exclude some plugins from VSCodium. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2181
Implemented changes:
excluded-editionsin the.propertiesof plugins that can be set with a list of comma-separated names of versions of IDEs. To make this change future-proof the filter for the new property is implemented in theinstallPlugins()-method of thePluginBasedCommandlet-class. This means that it can be used for other IDEs besides VSCode and VSCodium.excludedEditionsto theToolPluginDescriptor-record matching the new property of the pluginsgetPluginsConfigPath()-method of theVscode-class so that both VSCodium and VSCode share the same folder for the plugins. However to guarantee backward-compatibility, the method can optionally be changed so that if 'settings/vscodium/plugins/' exists and 'settings/vscode/plugings/' has no VSCodium-specific overrides the plugins in VSCodium directory are installed instead.VscodeTest.java.Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal