#2279: allow launching the GUI without an IDEasy project - #2285
Open
quando632 wants to merge 4 commits into
Open
#2279: allow launching the GUI without an IDEasy project#2285quando632 wants to merge 4 commits into
quando632 wants to merge 4 commits into
Conversation
The desktop shortcut runs "ideasy gui" and does not set a working directory, so the process starts outside of any IDEasy project. Gui did not override isIdeHomeRequired() and therefore inherited the default true, which made the commandlet abort with "The gui commandlet requires an IDEasy project to work". A desktop shortcut is by definition launched from outside a project, so it could never work. Gui now declares that IDE_HOME is not required. IDE_ROOT is still required, as both the launcher pom.xml and the project list are resolved relative to it. Project selection happens inside the GUI, which reads the available projects from IDE_ROOT via ProjectManager. Without IDE_HOME the mvn binary is no longer resolvable either: SystemPath.findBinary only searches tool2pathMap and paths, but never extraPathEntries, so ProcessContext.withPathEntry() does not influence the binary resolution of IDEasy itself. With IDE_HOME this never shows because tool2pathMap is populated from the software folder of the project. The bin directory of the resolved Maven installation is now registered in the SystemPath, analogous to what LocalToolCommandlet does after a fresh installation.
quando632
added
the
GUI
ToolCommandlet.createToolInstallation leaves binDir null when rootDir is null, and SystemPath.findBinaryInOrder resolves against the path without a null check. A null value in the tool map would therefore break the next binary lookup. LocalToolCommandlet applies the same guard before calling setPath.
…t IDE_HOME The registration is meant for the case the shortcut hits, where no project software folder exists to resolve mvn from. Inside a project the tool map is already filled from that folder, and since this commandlet requests the latest Maven rather than the configured one, registering it would silently run a different Maven version than before. The registration moved into registerMvnBinDir so both branches and the null bin directory can be covered by tests. Verified by mutation: without the IDE_HOME condition the in-project test fails, and without the null check the lookup fails with a NullPointerException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2279
The desktop shortcut added by #1917 is created correctly but never starts the GUI, because it launches
ideasy guifrom outside any IDEasy project.Implemented changes:
Guino longer requiresIDE_HOME.IDE_ROOTis still required, since the launcher pom and the project list resolve relative to it. Project selection happens inside the GUI, which reads the projects fromIDE_ROOTviaProjectManager.SystemPath. WithoutIDE_HOMEthere is no project software folder, somvnwas not resolvable and the launch failed withCreateProcess error=2.GuiTestcovering both the relaxedIDE_HOMErequirement and thatIDE_ROOTstays required.Testing instructions
mvn -o package -DskipTestsincli.IDE_HOMEset and change into a directory outside any IDEasy project, for example your home directory.guicommandlet from that directory.The gui commandlet requires an IDEasy project to work.Note that
ide-guimust be resolvable fromUSER_HOME/.m2or a remote repository, since withoutIDE_HOMEthe Maven configuration folder falls back toUSER_HOME/.m2(Mvn.java:282-283). On a SNAPSHOT developer installation you may need to runmvn -pl gui -am installfirst.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal